Generic plugin support

[daywalker90]

I've thought more about #487 and since CLN supports basically any language for plugins i propose to take this generic approach instead.
Non-python plugins put their requirements.txt and setup.sh in the tests folder (the one we already search for executing tests). The bash script will allow python developer to setup the plugin environment as they see fit.

Example setup.sh from my summars plugin and then a simple switch in my utils.py for local dev and CI

[chrisguida]

Neat! So we just require plugins to provide a release binary via a setup.sh script, and then we use that for the pytests?

[chrisguida]

If I run the CI now, will it test anything?

[daywalker90]

No because there is no non-python plugin that has passing tests in the repo merged atm. But i tested it on my fork (where i merged #485 and #486 and a special branch of #454 ) here:
https://github.com/daywalker90/plugins/actions/runs/7820798111/job/21336309829
EDIT: dont know why some tests are timing out on wait_for_channel, investigating
EDIT2: Seems like its a problem with cln master branch

[daywalker90]

Neat! So we just require plugins to provide a release binary via a setup.sh script, and then we use that for the pytests?

yes, the plugin author uses it in their tests, you don't have to do anything, see my utils.py i linked

[daywalker90]

I was in need of getting the python bin that is using the specific test env into the setup.sh. I think there could be some other use cases for this, so i added the env variable TEST_DIR.

[daywalker90]

rebased

[chrisguida]

ACK fb1637d

[chrisguida]

@Mergifyio queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

Pull request #491 has been dequeued due to failing checks or checks timeout.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[chrisguida]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed

[chrisguida]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at cb3145d