Pin poetry to 1.7.1 to fix tests for poetry-based plugins #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sip-21
changed the title
|
@cdecker are you okay with this change? We may need to update poetry to a newer version eventually, but it seems like 1.7.1 is ok for now? |
|
@sip-21 any idea how to fix the broken plugins if we unpin later? |
@chrisguida At this point, no. It might well be a problem with the new Poetry version, not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a temporary fix for the poetry-based backup and donations plugins whose tests are currently failing in CI. Recently released poetry v1.8 seems to cause problems in the current test setup. Pinning poetry to v1.7.1 makes the tests pass again.