Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove archived c-lightning-plugin-csvexportpays #514

Merged

Conversation

daywalker90
Copy link
Contributor

@0xB10C This plugin is archived and has no tests. It should therefore be removed.

@0xB10C
Copy link

0xB10C commented Apr 22, 2024

Agree! I don't plan to maintain it and haven't used it in multiple years.

.gitmodules Outdated
@@ -46,3 +43,6 @@
[submodule "watchtower-client"]
path = watchtower-client
url = https://github.com/talaia-labs/rust-teos
[submodule "cln-ntfy"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this submodule doing here?

@daywalker90 daywalker90 force-pushed the remove-c-lightning-plugin-csvexportpays branch from 3f1a859 to 52aa82c Compare April 22, 2024 21:24
@daywalker90
Copy link
Contributor Author

I removed that cln-ntfy entry in this PR

@chrisguida
Copy link
Collaborator

ACK 52aa82c

@chrisguida
Copy link
Collaborator

@Mergifyio queue

Copy link

mergify bot commented Apr 24, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@chrisguida
Copy link
Collaborator

@Mergifyio refresh

Copy link

mergify bot commented Apr 24, 2024

refresh

✅ Pull request refreshed

@chrisguida
Copy link
Collaborator

@Mergifyio queue

Copy link

mergify bot commented Apr 24, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@daywalker90 daywalker90 force-pushed the remove-c-lightning-plugin-csvexportpays branch from 52aa82c to d1c7b73 Compare April 24, 2024 18:27
Copy link
Collaborator

@chrisguida chrisguida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing to see if this approval auto-merges

@mergify mergify bot merged commit 40ab17f into lightningd:master Apr 24, 2024
9 checks passed
@daywalker90 daywalker90 deleted the remove-c-lightning-plugin-csvexportpays branch April 24, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants