revert: removes date from & symlink to log files #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
57a04f1
to
ee51f47
Compare
) This commit reverts the changes introduce by PR lightningdevkit#116 which added the date to log files when the node is started & a symlink to track the latest log file. This reversal is necessary to simplify the work required to integrate with OS-level log tools.
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
ee51f47
to
24cf565
Compare
tnull
reviewed
Nov 1, 2024
| @@ -1231,6 +1231,8 @@ fn build_with_store_internal( | |||
| }) | |||
| } | |||
|
|
|||
| /// Sets up the node logger, creating a new log file if it does not exist, or utilizing | |||
| /// the existing log file. | |||
| fn setup_logger(config: &Config) -> Result<Arc<FilesystemLogger>, BuildError> { | |||
| let log_dir = match &config.log_dir_path { | |||
| Some(log_dir) => String::from(log_dir), | |||
There was a problem hiding this comment.
Github won't comment on the line below this, but let's drop the {storage_path_dir}/logs folder now that we'll only have one log file. Rather, let's just default to {storage_path_dir}/ldk_node.log.
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
109ab9c
to
c030775
Compare
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
c030775
to
dc9f840
Compare
tnull
reviewed
Nov 4, 2024
- In addition, update docs for `ArcedNodeBuilder::set_log_file_path`
|
Thank you for the updates, mind rebasing on |
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
2 times, most recently
from
fc4aeb9
to
1eedcce
Compare
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
1eedcce
to
f033ba2
Compare
tnull
approved these changes
Nov 8, 2024
| fn setup_logger(config: &Config) -> Result<Arc<FilesystemLogger>, BuildError> { | ||
| let log_dir = match &config.log_dir_path { | ||
| let log_file_path = match &config.log_file_path { | ||
| Some(log_dir) => String::from(log_dir), |
There was a problem hiding this comment.
nit: This variable names should be adjusted to reflect it's now a file path, not the dir path anymore.
There was a problem hiding this comment.
Apologies for this. I'll address in another PR.
There was a problem hiding this comment.
No worries at all, let's just include a fixup commit in whatever logging-related PR you open next!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Reverts the changes introduce by #116 which added the dates to log files whenever the node is started & a symlink to track the latest log file. This reversal is necessary to simplify the work required to integrate with OS-level log tools.
Related Issue
loggerinterface #309