-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc updates to tee up async ChannelMonitorUpdate
persist for claims against closed channels
#3413
Open
TheBlueMatt
wants to merge
12
commits into
lightningdevkit:main
Choose a base branch
from
TheBlueMatt:2024-11-async-persist-claiming-from-closed-chan-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+248
−128
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
aba57bb
Make `test_durable_preimages_on_closed_channel` more robust
TheBlueMatt 19bf5ee
When removing `PeerState` check for in-flight mon updates deeply
TheBlueMatt 76119ce
Don't generate dup force-close `ChannelMonitorUpdate`s on startup
TheBlueMatt 0f7bc98
Handle events immediately if we are running during block connection
TheBlueMatt f191f09
f sp
TheBlueMatt ca7bd32
Add additional variants to `handle_new_monitor_update!`
TheBlueMatt b20e481
Add monitor update handling to `update_maps_on_chan_removal`
TheBlueMatt 8e48aa5
f simplify
TheBlueMatt 8def09d
f missing cfg-flagged update
TheBlueMatt 0101507
Properly enforce that all `ChannelMonitorUpdate`s are ordered
TheBlueMatt 03c1795
Check in-flight updates before completing events on closed chans
TheBlueMatt 55b712e
f clean up flow
TheBlueMatt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have test coverage for this fix?