corpus_merge.sh: make macOS compatible #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- xargs is needed to get rid of whitespace when getting the number of inputs - sed is used to strip non-numerical characters that appeared during the grep (notably the current working directory)
|
cc @morehouse |
morehouse
reviewed
Oct 20, 2023
| @@ -103,7 +103,7 @@ mkdir "${CACHE_DIR}/${FUZZ_TARGET}" | |||
| coverage=0 | |||
| if [[ -n $(ls "${DEST_DIR}") ]]; then | |||
| cp "${DEST_DIR}"/* "${CACHE_DIR}/${FUZZ_TARGET}/" | |||
| coverage=$(measure_coverage) | |||
| coverage=$(measure_coverage | sed 's/[^0-9]*//g') | |||
There was a problem hiding this comment.
What if the current directory has numbers in it?
Also, can we move the stripping of CWD into measure_coverage itself?
|
@Crypt-iQ, remember to re-request review from reviewers when ready |
|
Closing due to inactivity |
2 similar comments
|
Closing due to inactivity |
|
Closing due to inactivity |
|
!lightninglabs-deploy mute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried running
corpus_merge.shand ran into some issues due to quirks of macOS.wc -l, it would include whitespace. Now it gets piped toxargsto strip the whitespace.measure_coverage, the current working directory was included along with the coverage bits.sedis used to strip the non-numerical characters