Skip to content

Commit

Permalink
lntest: fix flakeness in openChannelsForNodes
Browse files Browse the repository at this point in the history
We now make sure the channel participants have heard their private
channel when opening channels.
  • Loading branch information
yyforyongyu committed Nov 26, 2024
1 parent f9c0cd5 commit d8d2a54
Showing 1 changed file with 17 additions and 2 deletions.
19 changes: 17 additions & 2 deletions lntest/harness.go
Original file line number Diff line number Diff line change
Expand Up @@ -2262,12 +2262,27 @@ func (h *HarnessTest) openChannelsForNodes(nodes []*node.HarnessNode,
}
resp := h.OpenMultiChannelsAsync(reqs)

// Make sure the nodes know each other's channels if they are public.
if !p.Private {
// If the channels are private, make sure the channel participants know
// the relevant channel.
if p.Private {
for i, chanPoint := range resp {
// Get the channel participants - for n channels we
// would have n+1 nodes.
nodeA, nodeB := nodes[i], nodes[i+1]
h.AssertChannelInGraph(nodeA, chanPoint)
h.AssertChannelInGraph(nodeB, chanPoint)
}
} else {
// Make sure the all nodes know all the channels if they are
// public.
for _, node := range nodes {
for _, chanPoint := range resp {
h.AssertChannelInGraph(node, chanPoint)
}

// Make sure every node has updated its cached graph
// about the edges as indicated in `DescribeGraph`.
h.AssertNumEdges(node, len(resp), false)
}
}

Expand Down

0 comments on commit d8d2a54

Please sign in to comment.