Claimed tokens overflow fix 2 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low bug to occur. The result of this bug is that any hatcher's tokens that are locked will remain locked and cannot be claimed. The problem is during CommonsToken._curvedBurn() the unlockedInternal variable is not limited to a max of initialRaise. This causes the incorrect calculation of the variable toUnlock in CommonsToken.claimTokens() to be incorrect and the function fails.
… internal tokens.
…tokens to external tokens.
ggarri
suggested changes
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overflow bug causes hatches tokens to be locked and unable to be claimed.
Rollback to this commit to make the bug happen:
7114bd3
Runn test 04_claim_tokens_overflow.js
The problem is that during CommonsToken._curvedBurn() the unlockedInternal variable needs to be limited to a max of initialRaise. Otherwise, this causes unlockedInternal to just keep increasing whenever tokens are burned. Then in CommonsToken.claimTokens() the incorrect calculation of the variable toUnlock occurs and the function fails when too many tokens are attempted to be transferred to the hatcher.