-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected erroneous caching example #73
Open
rebcabin
wants to merge
20
commits into
lihaoyi:master
Choose a base branch
from
rebcabin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instantiate instructions from earlier 30,000-ft overview section. It's too easy to miss the important instructions if you zoom straight to the demo section as many readers will do.
Sharpen distinction between defining a case class and using a case class. Hope this makes the task-oriented section of readme.md better.
Some other packages and modules actually break if they're imported after macropy (example: python-acoustics) because they assume that this parameter has the default value None.
Still have a couple failing, but this is a safety commit
I don't completely understand these exporter unit tests, and they required a little hacking to pass, but here they are.
unit tests coming next
A macro with semantics of the identity function that prints its expression and value as a side effect.
Some of this stuff may be indteresting, but it needs to be updated for python3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a misunderstanding of sharing of instance variables in my last pull request. This one corrects the misunderstanding and adds clarified examples, plus it has all the other commits I've made to date to get the unit tests to run.