Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement exclude operation #243

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat: implement exclude operation #243

merged 1 commit into from
Oct 17, 2024

Conversation

JabobKrauskopf
Copy link
Member

@JabobKrauskopf JabobKrauskopf commented Oct 17, 2024 •
edited
Loading

I implemented a exclude operation for basically all operands.

Example:

def query(node: NodeOperand) -> None:
    node.exclude(lambda node: node.attribute("age").greater_than(30))

I also fixed a tiny issue with either_or in NodeOperation and EdgeOperation

@JabobKrauskopf JabobKrauskopf linked an issue Oct 17, 2024 that may be closed by this pull request
Add .exclude(query) operand #242
Closed
@JabobKrauskopf JabobKrauskopf force-pushed the 242-add-excludequery-operand branch from 74fdc26 to af8cce4 Compare October 17, 2024 13:13
@JabobKrauskopf JabobKrauskopf marked this pull request as ready for review October 17, 2024 13:14
@JabobKrauskopf JabobKrauskopf requested review from a team as code owners October 17, 2024 13:14
@JabobKrauskopf JabobKrauskopf force-pushed the 242-add-excludequery-operand branch from af8cce4 to 23f29ba Compare October 17, 2024 13:29
MarIniOnz
MarIniOnz approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@MarIniOnz MarIniOnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DALLE2024-10-1716 06 26-ANavySEALsoldierinuniformhuggingananimatedseal Theanimatedsealshouldhaveafriendlyandcartoonishappearancewithlargeeyesandasmi-ezgif com-webp-to-jpg-converter

@JabobKrauskopf JabobKrauskopf merged commit a183c40 into main Oct 17, 2024
6 checks passed
@JabobKrauskopf JabobKrauskopf deleted the 242-add-excludequery-operand branch October 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarIniOnz MarIniOnz MarIniOnz approved these changes

@OFranke OFranke Awaiting requested review from OFranke OFranke is a code owner automatically assigned from limebit/medmodels-software-engineering

@FloLimebit FloLimebit Awaiting requested review from FloLimebit FloLimebit is a code owner automatically assigned from limebit/medmodels-software-engineering

@philippgrosser philippgrosser Awaiting requested review from philippgrosser philippgrosser is a code owner automatically assigned from limebit/medmodels-data-science-team

@LauraBoenchenLB LauraBoenchenLB Awaiting requested review from LauraBoenchenLB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .exclude(query) operand
2 participants
@JabobKrauskopf @MarIniOnz