LA-1238 removed hardcoded error code value

linagora · Apr 5, 2024 · 9eefacc · 9eefacc
1 parent 279547c
commit 9eefacc
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/data/lib/src/datasource_impl/authentication_datasource_impl.dart b/data/lib/src/datasource_impl/authentication_datasource_impl.dart
@@ -35,7 +35,6 @@ import 'package:data/data.dart';
 import 'package:data/src/network/model/response/user_response.dart';
 import 'package:dio/dio.dart';
 import 'package:domain/domain.dart';
-import 'package:flutter/foundation.dart';
 
 class AuthenticationDataSourceImpl implements AuthenticationDataSource {
 
@@ -106,7 +105,7 @@ class AuthenticationDataSourceImpl implements AuthenticationDataSource {
       _remoteExceptionThrower.throwRemoteException(error, handler: (DioError error) {
         final errorCode = error.response?.headers.value(Constant.linShareAuthErrorCode) ?? '1';
         final authErrorCode = LinShareErrorCode(int.tryParse(errorCode) ?? 1);
-          if(authErrorCode.value==1000){
+          if(authErrorCode.canNotGetJwt()){
             throw NotAuthorizedUser();
           }
         throw UnknownError(error.response?.statusMessage!);

diff --git a/domain/lib/src/errorcode/business_error_code.dart b/domain/lib/src/errorcode/business_error_code.dart
@@ -39,6 +39,7 @@ class BusinessErrorCode {
   static final workspaceLimit = LinShareErrorCode(50016);
   static final nestedWorkgroupLimit = LinShareErrorCode(55508);
   static final uploadRequestLimitReach = LinShareErrorCode(31416);
-  static final noValidTokenFound = [LinShareErrorCode(1005)];
+  static final noValidPermanentTokenFound = [LinShareErrorCode(1005)];
+  static final noValidJwt = [LinShareErrorCode(1000)];
 
 }
diff --git a/domain/lib/src/model/linshare_error_code.dart b/domain/lib/src/model/linshare_error_code.dart
@@ -43,6 +43,11 @@ extension LinShareErrorCodeExtension on LinShareErrorCode {
 
   bool isAuthenticateErrorUserLocked() =>
       BusinessErrorCode.authenErrorUserLocked.contains(this);
+
   bool isTokenDeleted()=>
-      BusinessErrorCode.noValidTokenFound.contains(this);
-}
+      BusinessErrorCode.noValidPermanentTokenFound.contains(this);
+
+  bool canNotGetJwt()=>
+      BusinessErrorCode.noValidJwt.contains(this);
+}
+