Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-1163] Implement OpenPaasRestClient #1228

Merged
merged 17 commits into from
Oct 17, 2024

Conversation

HoussemNasri
Copy link
Member

@HoussemNasri HoussemNasri commented Oct 10, 2024

Contributes to #1163

@HoussemNasri HoussemNasri changed the title Implement OpenPaasRestClient [ISSUE-1163] Implement OpenPaasRestClient Oct 10, 2024
@HoussemNasri HoussemNasri force-pushed the openpaas-rest-client branch 2 times, most recently from e622e54 to 80404bc Compare October 10, 2024 12:18
@chibenwa chibenwa marked this pull request as draft October 10, 2024 12:57
@HoussemNasri HoussemNasri marked this pull request as ready for review October 11, 2024 12:33
Copy link
Member

@Arsnael Arsnael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arsnael
Copy link
Member

Arsnael commented Oct 14, 2024

The submodule james is already based on that commit on master btw, please just rebase on latest master and update the submodule on the commit defined in master branch

git fetch linagora master
git rebase linagora/master
git submodule update

<artifactId>reactor-netty</artifactId>
</dependency>
<dependency>
<groupId>${james.groupId}</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project dependencies goes first,

@Arsnael
Copy link
Member

Arsnael commented Oct 15, 2024

Still conflicts, rebase please

@vttranlina
Copy link
Member

CI fail

[ERROR] Failed to execute goal io.github.evis:scalafix-maven-plugin_2.13:0.1.6_0.9.34:scalafix (scala-check-style) on project tmail-openpaas: Scalafix invoked with errors.

class OpenPaasServerExtension
Screenshot_20241015_172826

@HoussemNasri
Copy link
Member Author

CI failing again 😐

@chibenwa
Copy link
Member

I relaunched a build...

@Arsnael
Copy link
Member

Arsnael commented Oct 16, 2024

@Arsnael
Copy link
Member

Arsnael commented Oct 17, 2024

Still https://james-jenkins.lin-saas.com/job/Tmail%20build/job/PR-1228/9/

And still conflicts on the branch, needs a rebase.

@HoussemNasri do you actually test what you wrote locally before pushing or not? Every time I look on the build on the CI, the failures are mainly on the test class you wrote in this PR, aka OpenPaasRestClientTest

@HoussemNasri
Copy link
Member Author

HoussemNasri commented Oct 17, 2024

I have only run the tests in OpenPaasRestClientTest and they all passed. I used IntelliJ though, will try with maven.

@chibenwa chibenwa merged commit 89af559 into linagora:master Oct 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants