-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-1163] Implement OpenPaasRestClient #1228
Conversation
0d951cd
to
05860b1
Compare
e622e54
to
80404bc
Compare
...ckend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/OpenPaasConfiguration.java
Outdated
Show resolved
Hide resolved
...kend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/api/OpenPaasRestClient.java
Outdated
Show resolved
Hide resolved
...kend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/api/OpenPaasRestClient.java
Outdated
Show resolved
Hide resolved
...kend/tmail-third-party/openpaas/src/main/java/com/linagora/tmail/api/OpenPaasRestClient.java
Outdated
Show resolved
Hide resolved
...tmail-third-party/openpaas/src/test/scala/com/linagora/tmail/api/OpenPaasRestClientTest.java
Outdated
Show resolved
Hide resolved
...tmail-third-party/openpaas/src/test/scala/com/linagora/tmail/api/OpenPaasRestClientTest.java
Outdated
Show resolved
Hide resolved
...tmail-third-party/openpaas/src/test/scala/com/linagora/tmail/api/OpenPaasRestClientTest.java
Outdated
Show resolved
Hide resolved
...tmail-third-party/openpaas/src/test/scala/com/linagora/tmail/api/OpenPaasRestClientTest.java
Outdated
Show resolved
Hide resolved
...tmail-third-party/openpaas/src/test/scala/com/linagora/tmail/api/OpenPaasRestClientTest.java
Outdated
Show resolved
Hide resolved
...ail-third-party/openpaas/src/test/scala/com/linagora/tmail/api/OpenPaasServerExtension.scala
Outdated
Show resolved
Hide resolved
...ail-third-party/openpaas/src/test/scala/com/linagora/tmail/api/OpenPaasServerExtension.scala
Outdated
Show resolved
Hide resolved
...ail-third-party/openpaas/src/test/scala/com/linagora/tmail/api/OpenPaasServerExtension.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rebase conflict, needs to be solved
- No doc on this module configuration
- Error on test => https://james-jenkins.lin-saas.com/job/Tmail%20build/job/PR-1228/1/testReport/junit/com.linagora.tmail.api/OpenPaasRestClientTest/___/
The submodule james is already based on that commit on master btw, please just rebase on latest master and update the submodule on the commit defined in master branch
|
<artifactId>reactor-netty</artifactId> | ||
</dependency> | ||
<dependency> | ||
<groupId>${james.groupId}</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project dependencies goes first,
ce58b12
to
95250bd
Compare
Still conflicts, rebase please |
2fcf5fa
to
c15f103
Compare
CI failing again 😐 |
I relaunched a build... |
Still your OpenPaasRestClientTest class that is failing: |
Still https://james-jenkins.lin-saas.com/job/Tmail%20build/job/PR-1228/9/ And still conflicts on the branch, needs a rebase. @HoussemNasri do you actually test what you wrote locally before pushing or not? Every time I look on the build on the CI, the failures are mainly on the test class you wrote in this PR, aka OpenPaasRestClientTest |
I have only run the tests in OpenPaasRestClientTest and they all passed. I used IntelliJ though, will try with maven. |
Co-authored-by: Benoit TELLIER <[email protected]>
Co-authored-by: Benoit TELLIER <[email protected]>
Co-authored-by: Benoit TELLIER <[email protected]>
Co-authored-by: Benoit TELLIER <[email protected]>
Co-authored-by: Benoit TELLIER <[email protected]>
- For some reason this prevent the error in OpenPaasServerExtension: java.lang.NoClassDefFoundError: scala/Predef$
846c3db
to
47b9fea
Compare
Contributes to #1163