Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dimensions print statement #121

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Removing dimensions print statement #121

merged 1 commit into from
Nov 23, 2024

Conversation

aritraghsh09
Copy link
Collaborator

@aritraghsh09 aritraghsh09 commented Nov 23, 2024

The print statement somehow made it's way into main. it was causing I/O rate to exceed in Jupyter.

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.95%. Comparing base (4eb8301) to head (6c775b9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   40.93%   40.95%   +0.02%     
==========================================
  Files          21       21              
  Lines        1698     1697       -1     
==========================================
  Hits          695      695              
+ Misses       1003     1002       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@aritraghsh09 aritraghsh09 merged commit 7b3b992 into main Nov 23, 2024
8 checks passed
@aritraghsh09 aritraghsh09 deleted the print_dims_bugfix branch November 23, 2024 03:31
Copy link

Before [4eb8301] After [1d6fd16] Ratio Benchmark (Parameter)
3.01±1s 3.64±1s ~1.21 benchmarks.time_computation
2.66k 896 0.34 benchmarks.mem_list

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant