Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper multithreaded stats #60

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Proper multithreaded stats #60

merged 1 commit into from
Sep 11, 2024

Conversation

mtauraso
Copy link
Collaborator

  • Stats have their own thread for printing at a configurable cadence
  • There are 1 hr trailing window and cumulative stats
  • File rate is now reported as files/24h
  • Stats live in a separate file from the downloader
  • Stats code is (hopefully) easier to read

@mtauraso
Proper multithreaded stats
7ce85cb 
- Stats have their own thread for printing at a configurable cadence
- There are 1 hr trailing window and cumulative stats
- File rate is now reported as files/24h
- Stats live in a separate file from the downloader
- Stats code is (hopefully) easier to read
@mtauraso mtauraso self-assigned this Sep 10, 2024
@mtauraso mtauraso linked an issue Sep 10, 2024 that may be closed by this pull request
Add trailing window stats to Downloader. #59
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 124 lines in your changes missing coverage. Please review.

Project coverage is 38.90%. Comparing base (fde4c18) to head (7ce85cb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fibad/download_stats.py 0.00% 118 Missing ⚠️
src/fibad/download.py 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   42.16%   38.90%   -3.26%     
==========================================
  Files          16       17       +1     
  Lines         657      712      +55     
==========================================
  Hits          277      277              
- Misses        380      435      +55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Before [fde4c18] After [b95afc0] Ratio Benchmark (Parameter)
3.34±1s 2.47±0.4s ~0.74 benchmarks.time_computation
1.76k 464 0.26 benchmarks.mem_list

Click here to view all benchmarks.

drewoldag
drewoldag approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks pretty good to me. I like the abstraction that was done here.

aritraghsh09
aritraghsh09 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@aritraghsh09 aritraghsh09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@mtauraso mtauraso merged commit 3ee8380 into main Sep 11, 2024
7 of 9 checks passed
@mtauraso mtauraso deleted the issue/59/window-stats branch September 11, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewoldag drewoldag drewoldag approved these changes

@aritraghsh09 aritraghsh09 aritraghsh09 approved these changes

Assignees

@mtauraso mtauraso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add trailing window stats to Downloader.
3 participants
@mtauraso @aritraghsh09 @drewoldag