Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename to nested-dask #11

Merged
merged 3 commits into from
May 21, 2024
Merged

rename to nested-dask #11

merged 3 commits into from
May 21, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented May 21, 2024

Resolves #9

Copy link

github-actions bot commented May 21, 2024

Before [954ab73] After [8548fd5] Ratio Benchmark (Parameter)
failed 149M n/a benchmarks.NestedFrameAddNested.peakmem_run
failed 235±2ms n/a benchmarks.NestedFrameAddNested.time_run
failed 150M n/a benchmarks.NestedFrameQuery.peakmem_run
failed 485±3ms n/a benchmarks.NestedFrameQuery.time_run
failed 148M n/a benchmarks.NestedFrameReduce.peakmem_run
failed 373±2ms n/a benchmarks.NestedFrameReduce.time_run

Click here to view all benchmarks.

@dougbrn dougbrn requested a review from hombit May 21, 2024 17:41
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also fix two more things:

@dougbrn
Copy link
Collaborator Author

dougbrn commented May 21, 2024

Could you please also fix two more things:

@hombit good catch, done!

@dougbrn dougbrn requested a review from hombit May 21, 2024 18:51
@dougbrn dougbrn merged commit f2d5d69 into main May 21, 2024
7 checks passed
@dougbrn dougbrn deleted the rename_to_nested_dask branch May 23, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename to nested-dask for consistency
2 participants