Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wrapper functions: from_pandas, from_delayed, from_map #41

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Jul 3, 2024

Change Description

Resolves #33.

  • My PR includes a link to the issue that I am addressing

Solution Description

Implements 3 dask wrapper functions: from_pandas, from_delayed, and from_map. from_pandas works with both Pandas DataFrames and Nested-Pandas NestedFrames, so this PR also removes from_nested_pandas in favor of from_pandas

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dougbrn dougbrn changed the title add wrapper functions add wrapper functions: from_pandas, from_delayed, from_map Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Before [60cae9a] After [ef7679b] Ratio Benchmark (Parameter)
failed 150M n/a benchmarks.NestedFrameAddNested.peakmem_run
failed 212±1ms n/a benchmarks.NestedFrameAddNested.time_run
failed 151M n/a benchmarks.NestedFrameQuery.peakmem_run
failed 457±2ms n/a benchmarks.NestedFrameQuery.time_run
failed 148M n/a benchmarks.NestedFrameReduce.peakmem_run
failed 218±2ms n/a benchmarks.NestedFrameReduce.time_run

Click here to view all benchmarks.

@dougbrn dougbrn requested a review from smcguire-cmu July 3, 2024 17:51
Copy link
Contributor

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dougbrn dougbrn merged commit 73e988c into main Jul 3, 2024
8 checks passed
@dougbrn dougbrn deleted the more_wrappers branch July 3, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSDB Support: Wrappers to Persist NestedFrame dtype
2 participants