Use the right default value for include_notebooks #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This is a silly thing -
If you said "no" to
include_docs
, we didn't ask the question forinclude_notebooks
. And so we don't record an answer forinclude_notebooks
and the default answer from thecopier.yml
file is used in all places (which wasTrue
).This sets the default according to the answer from the
include_docs
: if we're not including docs, then don't include notebooks; if we're including docs, default to also including notebooks.Nearly all of the jinja in the rest of the template was doing the right thing, assuming you have correct values for
include_docs
andinclude_notebooks
.Closes #332
Checklist
lincc-frameworks/python-project-template
repo and not a downstream one instead.