-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a helper function for assembling a snia graph #210
Conversation
Click here to view all benchmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. My concern is now we lose the flexibility to define x1_func
in other ways since it's already pre-defined in this snia_x0_x1_from_host
function.
It is a trade off. The question for you is whether it is worth having this as a default implementation or whether the user should specify it themselves in the simulation (as in your demo notebook). I think either way will be fine. |
I think it's better to keep the way in the demo notebook, because it shows clearly how each function is defined. If user would like to keep all pre-defined functions we should wrap everything into one function instead of only wrapping x0 and x1. |
Sounds good. Closing this PR. |
Instead of having users always manually recreate all the nodes needed for each graph, we can prebuild sections of the graph.
snia_x0_x1_from_host()
creates and links the nodes used by snia models.