Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to use a default search radius for the OpSim #211

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

jeremykubica
Copy link
Contributor

Allow a default search radius so we can pass all the information needed for spatial matching together in a single OpSim object.

@jeremykubica jeremykubica requested a review from hombit January 2, 2025 20:09
Copy link

github-actions bot commented Jan 2, 2025

Before [080d28c] After [530644a] Ratio Benchmark (Parameter)
6.46±0.8ms 5.05±0.8ms ~0.78 benchmarks.TimeSuite.time_chained_evaluate
1.88±0.6ms 1.02±0.5ms ~0.54 benchmarks.TimeSuite.time_fnu_to_flam
1.40±0.06ms 1.46±0.04ms 1.04 benchmarks.TimeSuite.time_apply_passbands
9.86±0.2ms 9.99±0.3ms 1.01 benchmarks.TimeSuite.time_evaluate_salt3_model
4.98±0.1ms 4.99±0.2ms 1.00 benchmarks.TimeSuite.time_evaluate_salt3_passbands
8.75±0.06ms 8.71±0.09ms 1.00 benchmarks.TimeSuite.time_load_passbands
28.2±0.2μs 28.0±0.2μs 0.99 benchmarks.TimeSuite.time_make_new_salt3_model
130±2μs 128±1μs 0.98 benchmarks.TimeSuite.time_sample_x0_from_distmod
16.4±0.3μs 16.2±0.2μs 0.98 benchmarks.TimeSuite.time_sample_x1_from_hostmass
1.40±0.01s 1.36±0.01s 0.97 benchmarks.TimeSuite.time_make_x1_from_hostmass

Click here to view all benchmarks.

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jeremykubica jeremykubica merged commit 0386b25 into main Jan 3, 2025
5 checks passed
@jeremykubica jeremykubica deleted the opsim_radius branch January 3, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants