Passband integration #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… much for our use case)
hombit
reviewed
Jul 31, 2024
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-authored-by: Konstantin Malanchev <[email protected]>
…te to other download methods; switch to logging
…nsultation before I write the rest)
jeremykubica
reviewed
Aug 1, 2024
mi-dai
reviewed
Aug 1, 2024
This was referenced Aug 5, 2024
…e, expand docstring
Closed
jeremykubica
approved these changes
Aug 8, 2024
| True if the transmission table is successfully loaded, False otherwise. | ||
| """ | ||
| try: | ||
| self.transmission_tables[band_name] = np.loadtxt(file_path) |
There was a problem hiding this comment.
A consideration for a future PR. I think you might be able to simplify the user's workflow a bit if you always normalize the table as soon as it is loaded (instead of having the user manually call calculate_normalized_system_response_tables().
mi-dai
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Calculates normalized transmission tables along a grid of wavelengths with a 1 Angstrom step. We require users to match this grid with their input (or provide a model such as SplineModel that can generate wavelengths along an arbitrary grid).
When Kostya and I had initially discussed the strategy for this, we said (for now) the user should be in charge of matching the grid or providing such a model.
However, at some point we might want to add the ability to interpolate our normalized transmission tables to match an arbitrary user-generated grid.