Add action to update an existing issue #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leelasn
commented
Oct 11, 2024
leelasn
commented
- Adds an action to update an existing issue
- If the issue isn't changing teams, we need to populate team-specific options (project, status, labels) using the issue's current team, so this PR also updates the logic to populate those dropdowns accordingly
leelasn
force-pushed
the
leela/fea-2976-allow-updating-existing-issues-from-within-zapier
branch
from
e559bcd
to
c04218a
Compare
tommoor
approved these changes
Oct 16, 2024
| } | ||
|
|
||
| const updateIssueRequest = async (z: ZObject, bundle: Bundle) => { | ||
| if (!bundle.inputData.issueIdToUpdate) { |
There was a problem hiding this comment.
Just to differentiate since issueId is already used in another action and I didn't want to create any accidental side effects
| const response = await fetchFromLinear(z, bundle, issueQuery, { id: bundle.inputData.issueIdToUpdate }); | ||
| const data = response.json as IssueResponse; | ||
| const originalLabelIds = data.data.issue.labelIds; | ||
| labelIds = uniq([...originalLabelIds, ...bundle.inputData.labels]); |
There was a problem hiding this comment.
Man it would be nice if we had something in the API to enable adding/removing labels atomicly without having to fetch the entire set 🤔
| sample: { | ||
| data: { | ||
| id: "7b647c45-c528-464d-8634-eecea0f73033", | ||
| title: "Do the roar", |
There was a problem hiding this comment.
Can we make this sample data more realistic and not local.linear.dev 😉
leelasn
deleted the
leela/fea-2976-allow-updating-existing-issues-from-within-zapier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.