Add watchtower service to automatically upgrade the shard and proxy. #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christos-h
force-pushed
the
add-watchtower-docker-compose
branch
from
57ebebe to
ee548ee
Compare
ma2bd
reviewed
Dec 18, 2024
| container_name: watchtower | ||
| volumes: | ||
| - /var/run/docker.sock:/var/run/docker.sock | ||
| command: [ "--interval", "30", "proxy", "shard" ] |
There was a problem hiding this comment.
Are those minutes or seconds?
There was a problem hiding this comment.
It's seconds https://containrrr.dev/watchtower/arguments/#poll_interval
Seems like the default is 24h
ndr-ds
approved these changes
Dec 19, 2024
| container_name: watchtower | ||
| volumes: | ||
| - /var/run/docker.sock:/var/run/docker.sock | ||
| command: [ "--interval", "30", "proxy", "shard" ] |
There was a problem hiding this comment.
It's seconds https://containrrr.dev/watchtower/arguments/#poll_interval
Seems like the default is 24h
| container_name: watchtower | ||
| volumes: | ||
| - /var/run/docker.sock:/var/run/docker.sock | ||
| command: [ "--interval", "30", "proxy", "shard" ] |
There was a problem hiding this comment.
Maybe we should also pass --cleanup? To avoid old images accumulating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During testnet we would like validators to be updated automatically.
Proposal
Add watch-tower to
docker-compose.ymlmonitoring only the proxy and shards.Caveats
If a local image is used, automatic updating won't work since provenance is not shared with remote images.
This is a feature not a bug, if validators want they can build everything from scratch and opt-out from "forced" updates. However I see no reason why they might choose to.
Test Plan
Manual testing. CI will catch functional regressions.
Release Plan
testnetbranch, thenLinks
https://containrrr.dev/watchtower/