Move Hashed to linera-base.
#3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deuszx
approved these changes
Dec 19, 2024
ma2bd
reviewed
Dec 20, 2024
| @@ -439,6 +441,16 @@ pub struct LiteValue { | |||
| pub kind: CertificateKind, | |||
| } | |||
|
|
|||
| impl LiteValue { | |||
| pub fn new<T: CertificateValue>(value: &Hashed<T>) -> Self { | |||
There was a problem hiding this comment.
nit: This contructor is a bit weird. What was the issue with .lite()? Would a conversion From make sense?
There was a problem hiding this comment.
I can change it to a conversion.
The issue with .lite() is that I can't define the method in linera-chain because Hashed is now in linera-base. And I can't define it in linera-base because it needs the CertificateValue trait, which is in linera-chain.
There was a problem hiding this comment.
Personally I don't like From conversions which are not obvious. It makes it difficult to track the flow - it's impossible to look for w/ IDE's "find usage/references" feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are going to use
Hashedfor blobs, too, not only for certificate values.Proposal
Move it to
linera-base.Remove the
litemethod and create aLiteValue::newinstead.Also, rename
CertificateValueTtoCertificateValue.Test Plan
CI should catch regressions.
Release Plan
Links