Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus metrics #537

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dmitryilyin
Copy link

Add Prometheus metrics endpoint at "/metrics" with topic and consumer group measurements.

@bai
Copy link
Collaborator

bai commented May 27, 2019

Thanks for contributing. Could you please add tests for it?

53521191-7ea0e800-3aa5-11e9-8889-add122c24f51

@coveralls
Copy link

coveralls commented May 27, 2019

Coverage Status

Coverage decreased (-3.7%) to 71.012% when pulling 272f470 on dmitryilyin:prometheus_metrics into a449cc4 on linkedin:master.

@dmitryilyin
Copy link
Author

Hello! Ok, I'll make tests.

@mrueg
Copy link
Contributor

mrueg commented May 30, 2019

See also: https://github.com/jirwin/burrow_exporter/ (it might make sense to make use of prometheus golang libraries in your PR)

@shamil
Copy link

shamil commented May 30, 2019

Related issue #318

Copy link

@JensRantil JensRantil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered using https://godoc.org/github.com/prometheus/client_golang/prometheus instead of generating the https://prometheus.io/docs/instrumenting/exposition_formats/ manually yourself? The benefit of using the library is that you likely won't need to make any code changes if the exposition format changes. Additionally, you don't need to take care of string escaping and other low-level things.

@ledor473
Copy link

Any update on this pull request?

@bai is there a chance to get that merged if tests are added?
Is there even better chance it's merged if the client_golang is used?

@dmitryilyin do you have the bandwidth to tackle this or would you need help?

@bai
Copy link
Collaborator

bai commented Mar 17, 2020

I'd personally prefer having a native client_golang implementation since it's proven in production. I personally have no bandwidth to implement it though.

I won't hesitate reviewing a PR and releasing it if you or someone else would implement it 🙏

@paoloa21
Copy link

When will the feature be released?
Where Can I find the documentation for prometheus exporter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants