-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus metrics #537
base: master
Are you sure you want to change the base?
Conversation
Hello! Ok, I'll make tests. |
See also: https://github.com/jirwin/burrow_exporter/ (it might make sense to make use of prometheus golang libraries in your PR) |
Related issue #318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered using https://godoc.org/github.com/prometheus/client_golang/prometheus instead of generating the https://prometheus.io/docs/instrumenting/exposition_formats/ manually yourself? The benefit of using the library is that you likely won't need to make any code changes if the exposition format changes. Additionally, you don't need to take care of string escaping and other low-level things.
Any update on this pull request? @bai is there a chance to get that merged if tests are added? @dmitryilyin do you have the bandwidth to tackle this or would you need help? |
I'd personally prefer having a native client_golang implementation since it's proven in production. I personally have no bandwidth to implement it though. I won't hesitate reviewing a PR and releasing it if you or someone else would implement it 🙏 |
When will the feature be released? |
Add Prometheus metrics endpoint at "/metrics" with topic and consumer group measurements.