Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug fix: Drop
PRIMARY KEY
constraint fromKEY
fields. Instead, support newPRIMARY_KEY
"magic field" for the purpose.Drop MySQL from integration tests, since the images involved do not support ARM.
Details
Flink SQL supports a
PRIMARY KEY
constraint, but not allKEY
s can satisfy the constraint. In particular, keys that are nullable will cause problems.In addition, not all connectors support primary keys -- even if they do support keys. For example, the
kafka
connector does not seem to support primary keys, whereas theupsert-kafka
connector requires primary keys.To workaround this issue, we drop the
KEY
"magic field" and instead introduce aPRIMARY_KEY
"magic field". This enables adapters to useKEY
orPRIMARY_KEY
depending on the required semantics.Testing
The constraint was manually removed from existing pipelines.