Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release artifacts #75

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Update release artifacts #75

merged 7 commits into from
Dec 10, 2024

Conversation

ryannedolan
Copy link
Collaborator

@ryannedolan ryannedolan commented Dec 8, 2024

Summary

  • Added hoptimator-jdbc-driver fat jar artifact.
  • Added hoptimator-api artifact.
  • Moved Source, Sink, Job, Pipeline, and MaterializedView to hoptimator-api module.
  • Added SqlDialect enum.
  • Upgraded gradle.
  • Fixed non-determinism in tests.

Details

I endeavored to release the fewest number of artifacts while still being useful to downstream projects. For now, I think we can get away with just a driver "fat jar" and the API module. The hoptimator-util module is intended to make extending Hoptimator easier, but it should not be strictly necessary for most use cases.

The hoptimator-api module was missing Source, Sink, etc, which are necessary hooks to extend core functionality. I moved these to hoptimator-api. Otherwise the API wouldn't be particularly useful.

The Source and MaterializedView classes depended on Calcite's RelDataType and SqlDialect. I dropped methods and introduced our own SqlDialect enum to avoid introducing a dependency on Calcite. The API module should always have zero dependencies.

Testing Done

make integration-tests

@ryannedolan
Copy link
Collaborator Author

Thinking more about this, I'm going to change the SqlDialects to match the target engines: FLINK, ANSI for now. In particular, I think it will be nice to have flinksql in templates.

@ryannedolan ryannedolan force-pushed the update-release-artifacts branch from 5e64488 to 5288129 Compare December 9, 2024 22:58
@ryannedolan ryannedolan enabled auto-merge (squash) December 10, 2024 14:53
Copy link
Collaborator

@jogrogan jogrogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryannedolan ryannedolan merged commit 08729e9 into main Dec 10, 2024
1 check passed
@ryannedolan ryannedolan deleted the update-release-artifacts branch December 10, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants