Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hoptimator-jdbc-driver
fat jar artifact.hoptimator-api
artifact.Source
,Sink
,Job
,Pipeline
, andMaterializedView
tohoptimator-api
module.SqlDialect
enum.Details
I endeavored to release the fewest number of artifacts while still being useful to downstream projects. For now, I think we can get away with just a driver "fat jar" and the API module. The
hoptimator-util
module is intended to make extending Hoptimator easier, but it should not be strictly necessary for most use cases.The
hoptimator-api
module was missingSource
,Sink
, etc, which are necessary hooks to extend core functionality. I moved these tohoptimator-api
. Otherwise the API wouldn't be particularly useful.The
Source
andMaterializedView
classes depended on Calcite'sRelDataType
andSqlDialect
. I dropped methods and introduced our ownSqlDialect
enum to avoid introducing a dependency on Calcite. The API module should always have zero dependencies.Testing Done
make integration-tests