-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Venice support #78
Open
jogrogan
wants to merge
5
commits into
main
Choose a base branch
from
jogrogan/venice
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8ef69b0
Add Venice support
jogrogan 31d4ec6
Fix insert to exclude non-specified fields for Venice
jogrogan 5fb5687
Fix target column inserts
jogrogan 1973fe0
Address feedback, rebase to work with structured Key type, add tests
jogrogan e0e6ac9
Address feedback
jogrogan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
.gradle | ||
.idea/ | ||
/build | ||
*/build/ | ||
*/*.iml | ||
./models/external/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
services: | ||
zookeeper: | ||
image: venicedb/apache-zookeeper:3.9.0 | ||
container_name: zookeeper | ||
hostname: zookeeper | ||
healthcheck: | ||
test: ["CMD-SHELL", "echo ruok | nc zookeeper 2181"] | ||
start_period: 10s | ||
interval: 5s | ||
timeout: 5s | ||
retries: 5 | ||
|
||
kafka: | ||
image: venicedb/apache-kafka:3.3.1 | ||
container_name: kafka | ||
hostname: kafka | ||
environment: | ||
- ZOOKEEPER_ADDRESS=zookeeper:2181 | ||
depends_on: | ||
zookeeper: | ||
condition: service_healthy | ||
healthcheck: | ||
test: ["CMD-SHELL", "bash -x bin/kafka-topics.sh --bootstrap-server localhost:9092 --list"] | ||
start_period: 60s | ||
interval: 5s | ||
timeout: 20s | ||
retries: 5 | ||
|
||
venice-controller: | ||
image: venicedb/venice-controller:0.4.340 | ||
container_name: venice-controller | ||
hostname: venice-controller | ||
depends_on: | ||
kafka: | ||
condition: service_healthy | ||
ports: | ||
- 5555:5555 | ||
healthcheck: | ||
test: ["CMD-SHELL", "sleep 5"] | ||
start_period: 20s | ||
interval: 5s | ||
timeout: 20s | ||
retries: 5 | ||
|
||
venice-server: | ||
image: venicedb/venice-server:0.4.340 | ||
container_name: venice-server | ||
hostname: venice-server | ||
depends_on: | ||
venice-controller: | ||
condition: service_healthy | ||
healthcheck: | ||
test: ["CMD-SHELL", "sleep 5"] | ||
start_period: 20s | ||
interval: 5s | ||
timeout: 20s | ||
retries: 5 | ||
|
||
venice-router: | ||
image: venicedb/venice-router:0.4.340 | ||
container_name: venice-router | ||
hostname: venice-router | ||
depends_on: | ||
venice-server: | ||
condition: service_healthy | ||
ports: | ||
- 7777:7777 | ||
healthcheck: | ||
test: ["CMD-SHELL", "sleep 5"] | ||
start_period: 20s | ||
interval: 5s | ||
timeout: 20s | ||
retries: 5 | ||
|
||
venice-client: | ||
image: venicedb/venice-client:0.4.340 | ||
container_name: venice-client | ||
hostname: venice-client | ||
tty: true | ||
volumes: | ||
- ./venice:/opt/venice/schemas | ||
depends_on: | ||
venice-router: | ||
condition: service_healthy |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"type": "record", | ||
"name": "SampleTableKey", | ||
"doc": "SampleTableKey", | ||
"fields": [ | ||
{ | ||
"name": "id", | ||
"type": "int" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"type": "record", | ||
"name": "SampleTableValue", | ||
"doc": "SampleTableValue", | ||
"fields": [ | ||
{ | ||
"name": "intField", | ||
"type": [ | ||
"null", | ||
"int" | ||
], | ||
"default": null | ||
}, | ||
{ | ||
"name": "stringField", | ||
"type": [ | ||
"null", | ||
"string" | ||
], | ||
"default": null | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
apiVersion: hoptimator.linkedin.com/v1alpha1 | ||
kind: Database | ||
metadata: | ||
name: venice-cluster0 | ||
spec: | ||
schema: VENICE-CLUSTER0 | ||
url: jdbc:venice://cluster=venice-cluster0;router.url=http://localhost:7777 | ||
dialect: Calcite | ||
|
||
--- | ||
|
||
apiVersion: hoptimator.linkedin.com/v1alpha1 | ||
kind: TableTemplate | ||
metadata: | ||
name: venice-template-cluster0 | ||
spec: | ||
databases: | ||
- venice-cluster0 | ||
connector: | | ||
connector = venice | ||
storeName = {{table}} | ||
partial-update-mode = true | ||
key.fields-prefix = KEY_ | ||
key.fields = {{keys}} | ||
value.fields-include: EXCEPT_KEY |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to get
create table venice.foo
working :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I will spend some time looking into this when I can. Should be a simple API call just as I'm doing to fetch schemas, just different than the current paradigm since it isn't managed via K8s.