Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Efficient_Metadata_Operations] [DEPENDS_ON PR#2555] Handle purged blobs in store operations. #2578

Closed

Conversation

ankagrawal
Copy link
Collaborator

This PR handles purged blobs for store operations other than purge().

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Patch coverage: 20.45% and project coverage change: -0.09% ⚠️

Comparison is base (6622e11) 72.51% compared to head (094da9b) 72.43%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2578      +/-   ##
============================================
- Coverage     72.51%   72.43%   -0.09%     
- Complexity    11375    11380       +5     
============================================
  Files           803      803              
  Lines         64660    64744      +84     
  Branches       7897     7909      +12     
============================================
+ Hits          46890    46899       +9     
- Misses        15203    15269      +66     
- Partials       2567     2576       +9     
Files Changed Coverage Δ
.../github/ambry/notification/NotificationSystem.java 0.00% <ø> (ø)
...ain/java/com/github/ambry/protocol/RequestAPI.java 0.00% <ø> (ø)
...ava/com/github/ambry/cloud/AmbryCloudRequests.java 0.00% <0.00%> (ø)
.../main/java/com/github/ambry/cloud/VcrRequests.java 84.61% <0.00%> (-7.06%) ⬇️
...ithub/ambry/commons/LoggingNotificationSystem.java 47.22% <0.00%> (-2.78%) ⬇️
...n/java/com/github/ambry/protocol/PurgeRequest.java 0.00% <0.00%> (ø)
...in/java/com/github/ambry/server/AmbryRequests.java 71.83% <0.00%> (-3.45%) ⬇️
...rc/main/java/com/github/ambry/store/BlobStore.java 83.94% <0.00%> (-0.93%) ⬇️
...n/java/com/github/ambry/store/PersistentIndex.java 90.28% <33.33%> (-0.21%) ⬇️
...n/java/com/github/ambry/store/StoreErrorCodes.java 100.00% <100.00%> (ø)
... and 3 more

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankagrawal ankagrawal closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants