Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap Performance Improvement[PR2] : Adding Network Protocol Classes For File Copy And Implementation For Handling Async File Copy Termination #2969

Merged
merged 16 commits into from
Dec 20, 2024
Merged

Bootstrap Performance Improvement[PR2] : Adding Network Protocol Classes For File Copy And Implementation For Handling Async File Copy Termination #2969

merged 16 commits into from
Dec 20, 2024

Conversation

aga9900
Copy link
Contributor

@aga9900 aga9900 commented Dec 18, 2024 •
edited
Loading

The PR contains following:

  1. FileCopyReplicationGetMetaDataRequest + Test cases
  2. FileCopyReplicationGetMetaDataResponse + Test cases
  3. FileCopyReplicationGetChunkRequest + Test Cases

justinlin-linkedin
justinlin-linkedin reviewed Dec 19, 2024
View reviewed changes
ambry-protocol/src/main/java/com/github/ambry/protocol/FileCopyProtocolGetChunkRequest.java Outdated Show resolved Hide resolved
ambry-protocol/src/main/java/com/github/ambry/protocol/FileCopyProtocolGetChunkRequest.java Outdated Show resolved Hide resolved
ambry-protocol/src/main/java/com/github/ambry/protocol/FileCopyProtocolGetChunkResponse.java Outdated Show resolved Hide resolved
ambry-protocol/src/main/java/com/github/ambry/protocol/FileCopyProtocolGetChunkRequest.java Outdated Show resolved Hide resolved
ambry-protocol/src/main/java/com/github/ambry/protocol/FileCopyProtocolGetChunkResponse.java Outdated Show resolved Hide resolved
ambry-protocol/src/main/java/com/github/ambry/protocol/FileCopyProtocolGetChunkResponse.java Outdated Show resolved Hide resolved
ambry-protocol/src/main/java/com/github/ambry/protocol/FileCopyProtocolGetMetaDataRequest.java Outdated Show resolved Hide resolved
ambry-protocol/src/main/java/com/github/ambry/protocol/FileCopyProtocolGetChunkResponse.java Outdated Show resolved Hide resolved
ambry-protocol/src/main/java/com/github/ambry/protocol/LogInfo.java Outdated Show resolved Hide resolved
ambry-protocol/src/main/java/com/github/ambry/protocol/FileCopyProtocolGetMetaDataResponse.java Outdated Show resolved Hide resolved
piyujai
piyujai requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@piyujai piyujai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comments and add positive, negative, null check, exception, etc tests for all the classes and methods added.

@aga9900 aga9900 requested review from piyujai and removed request for piyujai December 20, 2024 18:32
@aga9900 aga9900 merged commit 1bc7fa0 into master Dec 20, 2024
3 of 4 checks passed
@aga9900 aga9900 deleted the bootstrap-performance-improvement-2 branch December 20, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyujai piyujai piyujai requested changes

@justinlin-linkedin justinlin-linkedin justinlin-linkedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aga9900 @piyujai @justinlin-linkedin