fixing ide lint unnncessary changes

linkedin · Oct 31, 2022 · aafad66 · aafad66
1 parent 6950dc9
commit aafad66
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/coral-common/src/main/java/com/linkedin/coral/common/ToRelConverter.java b/coral-common/src/main/java/com/linkedin/coral/common/ToRelConverter.java
@@ -160,8 +160,7 @@ public SqlNode processView(String dbName, String tableName) {
 
   public RelNode toRel(SqlNode sqlNode) {
     RelRoot root = getSqlToRelConverter().convertQuery(sqlNode, true, true);
-    RelNode relNode = standardizeRel(root.rel);
-    return relNode;
+    return standardizeRel(root.rel);
   }
 
   /**

diff --git a/coral-hive/src/main/java/com/linkedin/coral/hive/hive2rel/parsetree/ParseTreeBuilder.java b/coral-hive/src/main/java/com/linkedin/coral/hive/hive2rel/parsetree/ParseTreeBuilder.java
@@ -203,7 +203,7 @@ private SqlNode visitLateralViewUDTF(List<SqlNode> sqlNodes, List<SqlNode> alias
   }
 
   private SqlNode visitLateralViewExplode(List<SqlNode> sqlNodes, List<SqlNode> aliasOperands,
-     SqlCall tableFunctionCall, boolean isOuter) {
+      SqlCall tableFunctionCall, boolean isOuter) {
     final int operandCount = aliasOperands.size();
     // explode array if operandCount == 3: LATERAL VIEW EXPLODE(op0) op1 AS op2
     // explode map if operandCount == 4: LATERAL VIEW EXPLODE(op0) op1 AS op2, op3
@@ -257,7 +257,7 @@ private SqlNode visitLateralViewExplode(List<SqlNode> sqlNodes, List<SqlNode> al
 
     // For POSEXPLODE case, we need to change the order of 2 alias. i.e. `pos, val` -> `val, pos` to be aligned with calcite validation
     if (operator instanceof CoralSqlUnnestOperator && ((CoralSqlUnnestOperator) operator).withOrdinality
-            && operandCount == 4) {
+        && operandCount == 4) {
       asOperands.add(aliasOperands.get(1));
       asOperands.add(aliasOperands.get(3));
       asOperands.add(aliasOperands.get(2));
@@ -304,9 +304,9 @@ LATERAL VIEW json_tuple(json, p1, p2) jt AS a, b
               ImmutableList.of(jsonInput, jsonPath), null);
       // TODO Hive get_json_object returns a string, but currently is mapped in Trino to json_extract which returns a json. Once fixed, remove the CAST
       SqlCall castToString = SqlStdOperatorTable.CAST.createCall(ZERO, getJsonObjectCall,
-              // TODO This results in CAST to VARCHAR(65535), which may be too short, but there seems to be no way to avoid that.
-              //  even `new SqlDataTypeSpec(new SqlBasicTypeNameSpec(SqlTypeName.VARCHAR, Integer.MAX_VALUE - 1, ZERO), ZERO)` results in a limited VARCHAR precision.
-              createBasicTypeSpec(SqlTypeName.VARCHAR));
+          // TODO This results in CAST to VARCHAR(65535), which may be too short, but there seems to be no way to avoid that.
+          //  even `new SqlDataTypeSpec(new SqlBasicTypeNameSpec(SqlTypeName.VARCHAR, Integer.MAX_VALUE - 1, ZERO), ZERO)` results in a limited VARCHAR precision.
+          createBasicTypeSpec(SqlTypeName.VARCHAR));
       // TODO support jsonKey containing a quotation mark (") or backslash (\)
       SqlCall ifCondition =
           HiveRLikeOperator.RLIKE.createCall(ZERO, jsonKey, SqlLiteral.createCharString("^[^\\\"]*$", ZERO));
@@ -318,7 +318,7 @@ LATERAL VIEW json_tuple(json, p1, p2) jt AS a, b
     }
 
     SqlNode select =
-            new SqlSelect(ZERO, null, new SqlNodeList(projections, ZERO), null, null, null, null, null, null, null, null);
+        new SqlSelect(ZERO, null, new SqlNodeList(projections, ZERO), null, null, null, null, null, null, null, null);
     SqlNode lateral = SqlStdOperatorTable.LATERAL.createCall(ZERO, select);
     SqlCall lateralAlias = SqlStdOperatorTable.AS.createCall(ZERO,
         ImmutableList.<SqlNode> builder().add(lateral).addAll(aliasOperands.subList(1, aliasOperands.size())).build());