KAFKA-8583: Optimization for SslTransportLayer#write(ByteBuffer) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warp data as many as possible in SslTransportLayer#write(ByteBuffer) The change comes from Ambry, whose TransportLayer code is same with Kafka. linkedin/ambry#1105
|
Can you provide a more readable explanation of your change? What do you mean by "warp"? |
|
Also if this is not a hot fix (i.e. we don't need it to fix something immediately) then why not just submit this to upstream Kafka and go though their process. We will cherry pick it or rebase on changes on top of this. |
andrewchoi5
reviewed
Jan 23, 2020
| //handle ssl renegotiation | ||
| if (wrapResult.getHandshakeStatus() != HandshakeStatus.NOT_HANDSHAKING && wrapResult.getStatus() == Status.OK) | ||
| throw renegotiationException(); | ||
| //handle ssl renegotiation |
There was a problem hiding this comment.
nit: whitespace between // and handle
| @@ -630,37 +630,42 @@ public long read(ByteBuffer[] dsts, int offset, int length) throws IOException { | |||
| */ | |||
There was a problem hiding this comment.
In the commit message, warp or wrap?
MayureshGharat
force-pushed
the
2.0-li
branch
from
a110124 to
6bfd49b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warp data as many as possible in SslTransportLayer#write(ByteBuffer)
The change comes from Ambry, whose TransportLayer code is same with Kafka.
linkedin/ambry#1105
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)