Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LI-HOTFIX] Add comment to explain the safety of the brokerEpochSupplier method #412

Draft
wants to merge 1 commit into
base: 3.0-li
Choose a base branch
from
Draft

[LI-HOTFIX] Add comment to explain the safety of the brokerEpochSupplier method #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/main/scala/kafka/server/KafkaServer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,13 @@ class KafkaServer(
time = time,
metrics = metrics,
threadNamePrefix = threadNamePrefix,
/**
* Since the kafkaController object is initialized later in this method, there is the question of whether the brokerEpochSupplier can
* trigger NullPointerExceptions. That should not happen because there is a implicit barrier:
* 1. The Partition objects are created when processing the LeaderAndISR requests, and only after they are created can the brokerEpochSupplier be called.
* 2. Processing an LeaderAndISR request won’t be possible until the {@link SocketServer.startProcessingRequests()} method is called
* toward the end of this method.
*/
brokerEpochSupplier = () => kafkaController.brokerEpoch,
config.brokerId
)
Expand Down