Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LI-HOTFIX] Add visibility to usage of ListOffsets by timestamp #478

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

lmr3796
Copy link

@lmr3796 lmr3796 commented Oct 6, 2023

LI_DESCRIPTION = LIKAFKA-54997
EXIT_CRITERIA = When such information is no longer needed

For the Northguard use case, we want to know what's the load on ListOffsets API used with "search by timestamp".
This patch exposes the visibility to

  1. Partitions per second requested for listOffset by each type (earliest, by timestamp, latest, etc.)
  2. Exposes the logging for "what are the principals querying such case"
  3. Distribution of partitions included per request.

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@lmr3796 lmr3796 force-pushed the instrument-list-offset branch from ab23dec to bedfd0b Compare October 6, 2023 06:37
@lmr3796 lmr3796 force-pushed the instrument-list-offset branch from bedfd0b to dfb5ee0 Compare October 6, 2023 06:38
@lmr3796 lmr3796 requested a review from CCisGG October 6, 2023 19:28
@lmr3796 lmr3796 enabled auto-merge (squash) October 6, 2023 22:11
@lmr3796 lmr3796 merged commit d6694e5 into 3.0-li Oct 6, 2023
25 checks passed
@lmr3796 lmr3796 deleted the instrument-list-offset branch October 6, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants