[LI-HOTFIX] Add federated topic znode create rpc #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmr3796
suggested changes
Oct 25, 2023
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
Outdated
Show resolved
Hide resolved
lmr3796
suggested changes
Oct 26, 2023
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java
Outdated
Show resolved
Hide resolved
kehuum
changed the title
lmr3796
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds create federated topic znode rpc that creates a znode entry under /federatedTopics/topicName (value = namespace name).
LI_DESCRIPTION =
In order to make kafka broker understand new acl, it will need to understand the topic name and its corresponding namespace. So when a new kafka topic is created by xmd-service, a corresponding znode will also be created in the above new znode directory so that kafka broker will use the namespace stored to construct the new acl urn correctly.
Added integ-test, verification will be added later after we have added delete federated topic rpcs.
EXIT_CRITERIA = We can deprecate this pr and following delete federated topic rpc pr when all kafka clients have been migrated to xinfra clients and all topic CUDs go through xmd, then we don't need kafka broker to understand both old and new topic acl, it will only need to understand the new acl.
Committer Checklist (excluded from commit message)