Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LI-HOTFIX] Add federated topic znode delete rpc #481

Merged
merged 2 commits into from
Oct 30, 2023
Merged

[LI-HOTFIX] Add federated topic znode delete rpc #481

merged 2 commits into from
Oct 30, 2023

Conversation

kehuum
Copy link

@kehuum kehuum commented Oct 20, 2023

This PR adds

  1. delete federated topic rpc that deletes the znode entry under /federatedTopics/topicName (value = namespace name)
  2. zk function to get all federated topics as a set of string, in the format of /namespaceName/topicName for easier usage and avoid duplicate code in kafka-server

LI_DESCRIPTION =
In order to make kafka broker understand new acl, it will need to understand the topic name and its corresponding namespace. So when a new kafka topic is deleted by xmd-service, the corresponding znode will also be deleted in the above new znode directory.

Added integ-test to verify create and delete logic

EXIT_CRITERIA = We can deprecate this pr when all kafka clients have been migrated to xinfra clients and all topic CUDs go through xmd, then we don't need kafka broker to understand both old and new topic acl, it will only need to understand the new acl.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@kehuum kehuum force-pushed the remainrpc branch 3 times, most recently from 85fb153 to 6a578f6 Compare October 27, 2023 23:43
@kehuum kehuum changed the title Remainrpc [LI-HOTFIX] Add federated topic znode delete rpc Oct 27, 2023
@kehuum kehuum merged commit a1ca402 into 3.0-li Oct 30, 2023
25 checks passed
@kehuum kehuum deleted the remainrpc branch October 30, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants