Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LI-CHERRY-PICK] KAFKA-14887: FinalizedFeatureChangeListener should not shut down when ZK session expires #484

Merged
merged 4 commits into from
Nov 1, 2023
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,12 @@ class FinalizedFeatureChangeListener(private val finalizedFeatureCache: Finalize
// safe to ignore the exception if the thread is being shutdown. We raise the exception
// here again, because, it is ignored by ShutdownableThread if it is shutting down.
throw ie
case e: Exception => {
error("Failed to process feature ZK node change event. The broker will eventually exit.", e)
case cacheUpdateException: FeatureCacheUpdateException =>
error("Failed to process feature ZK node change event. The broker will eventually exit.", cacheUpdateException)
throw new FatalExitError(1)
}
case e: Exception =>
lmr3796 marked this conversation as resolved.
Show resolved Hide resolved
// do not exit for exceptions unrelated to cache change processing (e.g. ZK session expiration)
warn("Unexpected exception in feature ZK node change event processing; will continue processing.", e)
}
}
}
Expand Down
Loading