[LI-HOTFIX] Add list federated topic znodes rpc #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kehuum
changed the title
kehuum
force-pushed
the
addList
branch
3 times, most recently
from
c08cd7c to
55f460b
Compare
lmr3796
suggested changes
Nov 6, 2023
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
Outdated
Show resolved
Hide resolved
clients/src/main/resources/common/message/LiListFederatedTopicZnodesRequest.json
Outdated
Show resolved
Hide resolved
lmr3796
suggested changes
Nov 6, 2023
lmr3796
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds list federated topic znodes rpc that either list all federated topic znodes, or only given federated topic znodes matching the input simple topic names.
LI_DESCRIPTION =
To make all zk access go through kafka broker, in addition to the previous create/delete federated topic znodes rpcs, we also need to add read/list federated topic znodes rpc.
Added integ-test to verify list federated topic znode api
EXIT_CRITERIA = We can deprecate this pr when all kafka clients have been migrated to xinfra clients and all topic CUDs go through xmd, then we don't need kafka broker to understand both old and new topic acl, it will only need to understand the new acl.
Committer Checklist (excluded from commit message)