Add max request count limit for LiCombinedControlRequest #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing as this is likely not helping because on controller failover there is going to be a single huge MetadataRequest that blocks the controller send queue. |
groelofs
reviewed
Aug 28, 2024
| // Fixme: tmp fix for incident-1517. We tried to merge limited amount of requests to a single LiCombinedControlRequest | ||
| // so that a single request size is not larger than max limit which is 100MB. | ||
| var counter = maxRequestCountToMerge | ||
| while (!queue.isEmpty && shouldContinueMerging && maxRequestCountToMerge > 0) { |
There was a problem hiding this comment.
This is a do-nothing change because maxRequestCountToMerge is always > 0. You want counter in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a temporary fix for incident-1517. We tried to merge limited amount of requests to a single LiCombinedControlRequest, so that a single request size is not larger than max limit which is 100MB. We should revert it once the incident is mitigated.
Committer Checklist (excluded from commit message)