Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating upstream to catchup to the internal repo #54

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Updating upstream to catchup to the internal repo #54

merged 2 commits into from
Mar 21, 2024

Conversation

sumedhsakdeo
Copy link
Collaborator

@sumedhsakdeo sumedhsakdeo commented Mar 21, 2024 •
edited
Loading

Summary

Major features include:

  1. Orphan Table Directory Deletion (by @y242yang)
  2. Write Audit Publish (by @jiang95-dev)
  3. Tables Stats Collector (by @maluchari)
  4. AclPolicies properties and expiration (by @abhisheknath2011)
  5. Retention policy default (by @rohitkum2506)

Changes

  • Client-facing API Changes
  • Internal API Changes
  • Bug Fixes
  • New Features
  • Performance Improvements
  • Code Style
  • Refactoring
  • Documentation
  • Tests

For all the boxes checked, please include additional details of the changes made in this pull request.

Testing

  • Manually Tested on local docker setup. Please include commands ran, and their output.
  • Added new tests for the changes made.
  • Updated existing tests to reflect the changes made.
  • No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
  • Some other form of testing like staging or soak time in production. Please explain.

For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.

Additional Information

  • Breaking Changes
  • Deprecations
  • Large PR broken into smaller PRs, and PR plan linked in the description.

For all the boxes checked, include additional details of the changes made in this pull request.

abhisheknath2011
abhisheknath2011 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@abhisheknath2011 abhisheknath2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wow good number of files to merge!

maluchari
maluchari approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@maluchari maluchari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y242yang
y242yang approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@y242yang y242yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sumedhsakdeo sumedhsakdeo merged commit c4e5fed into linkedin:main Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y242yang y242yang y242yang approved these changes

@maluchari maluchari maluchari approved these changes

@abhisheknath2011 abhisheknath2011 abhisheknath2011 approved these changes

@rohitkum2506 rohitkum2506 Awaiting requested review from rohitkum2506

@jiang95-dev jiang95-dev Awaiting requested review from jiang95-dev

Assignees

@teamurko teamurko

@autumnust autumnust

@HotSushi HotSushi

@manishakml manishakml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sumedhsakdeo @abhisheknath2011 @maluchari @y242yang @teamurko @autumnust @HotSushi @manishakml