Skip to content

Commit

Permalink
update jmx and mbean method names
Browse files Browse the repository at this point in the history
  • Loading branch information
bohhyang committed Oct 31, 2024
1 parent 8fb85a8 commit bdba636
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public class ZooKeeperAnnouncer implements D2ServiceDiscoveryEventHelper
/**
* Whether the announcer has completed sending a dark warmup cluster markup intent.
*/
private final AtomicBoolean _isDarkWarmupMarkedUp = new AtomicBoolean(false);
private final AtomicBoolean _isDarkWarmupMarkUpIntentSent = new AtomicBoolean(false);

// String to store the name of the dark warm-up cluster, defaults to null
private final String _warmupClusterName;
Expand Down Expand Up @@ -455,7 +455,7 @@ public void onError(Throwable e)
@Override
public void onSuccess(None result)
{
_isDarkWarmupMarkedUp.set(false);
_isDarkWarmupMarkUpIntentSent.set(false);
emitSDStatusActiveUpdateIntentAndWriteEvents(_warmupClusterName, false, true, _warmupClusterMarkDownStartAtRef.get());
// Mark _isWarmingUp to false to indicate warm up has completed
_isWarmingUp = false;
Expand Down Expand Up @@ -506,7 +506,7 @@ public void onError(Throwable e)
@Override
public void onSuccess(None result)
{
_isDarkWarmupMarkedUp.set(true);
_isDarkWarmupMarkUpIntentSent.set(true);
emitSDStatusActiveUpdateIntentAndWriteEvents(_warmupClusterName, true, true, _warmupClusterMarkUpStartAtRef.get());
_log.info("markUp for uri {} on warm-up cluster {} succeeded", _uri, _warmupClusterName);
// Mark _isWarmingUp to true to indicate warm up is in progress
Expand Down Expand Up @@ -819,14 +819,14 @@ public boolean isMarkUpFailed()
return _markUpFailed;
}

public boolean isMarkedUp()
public boolean isMarkUpIntentSent()
{
return _isMarkUpIntentSent.get();
}

public boolean isDarkWarmupMarkedUp()
public boolean isDarkWarmupMarkUpIntentSent()
{
return _isDarkWarmupMarkedUp.get();
return _isDarkWarmupMarkUpIntentSent.get();
}

public int getMaxWeightBreachedCount()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,14 +185,14 @@ public boolean isMarkUpFailed() {
}

@Override
public boolean isMarkedUp()
public boolean isMarkUpIntentSent()
{
return _announcer.isMarkedUp();
return _announcer.isMarkUpIntentSent();
}

@Override
public boolean isDarkWarmupMarkedUp() {
return _announcer.isDarkWarmupMarkedUp();
public boolean isDarkWarmupMarkUpIntentSent() {
return _announcer.isDarkWarmupMarkUpIntentSent();
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,16 @@ void setPartitionDataUsingJson(String partitionDataJson)
boolean isMarkUpFailed();

/**
* @return true if the announcer is marked up.
* @return true if the announcer has completed sending a markup intent. NOTE THAT a mark-up intent sent does NOT mean the
* announcement status on service discovery registry is up. Service discovery registry may further process the host
* and determine its status. Check on service discovery registry for the final status.
*/
boolean isMarkedUp();
boolean isMarkUpIntentSent();

/**
* @return true if the announcer marked up the dark warmup cluster.
* @return true if the announcer has completed sending a dark warmup cluster markup intent.
*/
boolean isDarkWarmupMarkedUp();
boolean isDarkWarmupMarkUpIntentSent();

/**
* @return the times that the max weight has been breached.
Expand All @@ -90,7 +92,7 @@ void setPartitionDataUsingJson(String partitionDataJson)

/**
*
* @return the times that the max number of decimal places on weight have been breached.
* @return the times that the max number of decimal places on weight has been breached.
*/
int getWeightDecimalPlacesBreachedCount();
}

0 comments on commit bdba636

Please sign in to comment.