Respect startPublishing call by always re-notifying watcher in XdsClientImpl
#1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lientImpl When switching from the backup to the primary store (implemented in the XdsClientImpl), the data in the primary store is never replayed. This is different from the backup store behavior which respects the invocation of startPublishing and replays the contents of the store. This means that if the contents of the backup store are different from the contents of the primary store, and the client switches from the backup to the primary, the client will only see the backup values and not the primary values.
shivamgupta1
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching from the backup to the primary store (implemented in the XdsClientImpl), the data in the primary store is never replayed. This is different from the backup store behavior which respects the invocation of startPublishing and replays the contents of the store. This means that if the contents of the backup store are different from the contents of the primary store, and the client switches from the backup to the primary, the client will only see the backup values and not the primary values.