Allow for null paging inside Collection response envelopes #1019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for null paging inside Collection response envelopes. Some use cases don't want to use index based pagination and instead want a custom pagination mechanism using custom metadata.
In such cases, the framework injected default index based pagination is confusing for their clients. Supporting this natively within the framework is risky and fragile, since it involves changes to many places to undo the assumption that index based pagination always exists.
However, it is possible to put in a workaround by asking the services interested to author a custom rest.li filter to strip out index based pagination in such cases from the response. However, for such a filter to work this particular change is needed since the code that converts collection response envelopes to
CollectionResponse
objects needs to be aware of cases where pagination can be null.