Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for null paging inside Collection response envelopes #1019

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

karthikrg
Copy link
Contributor

Allow for null paging inside Collection response envelopes. Some use cases don't want to use index based pagination and instead want a custom pagination mechanism using custom metadata.

In such cases, the framework injected default index based pagination is confusing for their clients. Supporting this natively within the framework is risky and fragile, since it involves changes to many places to undo the assumption that index based pagination always exists.

However, it is possible to put in a workaround by asking the services interested to author a custom rest.li filter to strip out index based pagination in such cases from the response. However, for such a filter to work this particular change is needed since the code that converts collection response envelopes to CollectionResponse objects needs to be aware of cases where pagination can be null.

@mchen07 mchen07 merged commit 5b3e6cc into linkedin:master Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants