Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add announcer status delegate interface and support getting server announce mode #1035

Merged
merged 5 commits into from
Nov 23, 2024
Merged

Add announcer status delegate interface and support getting server announce mode #1035

merged 5 commits into from
Nov 23, 2024

Conversation

bohhyang
Copy link
Contributor

@bohhyang bohhyang commented Nov 18, 2024 •
edited
Loading

Summary

  1. Added announcer status delegate interface and implemented it in ZooKeeperAnnouncer to reflect its status.
  2. Made LoadBalancerServer reports its announcing mode: statically announcing or dynamically announcing (could change at runtime) to the old or new service registry, or both.
  3. Added ZooKeeperAnnouncer's JMX method to report its server's announcing mode.

All changes are to support the container PR.

Test Done

See container PR for UT and qei deploy test.

ZoabKapoor
ZoabKapoor approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ZoabKapoor ZoabKapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

d2/src/main/java/com/linkedin/d2/balancer/LoadBalancerServer.java Show resolved Hide resolved
@bohhyang bohhyang merged commit 1eeec25 into master Nov 23, 2024
2 checks passed
@bohhyang bohhyang deleted the by/lixDualWrite branch November 23, 2024 16:13
@bohhyang bohhyang mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycezhongqing brycezhongqing brycezhongqing left review comments

@ZoabKapoor ZoabKapoor ZoabKapoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bohhyang @ZoabKapoor @brycezhongqing