[#555] Response-only Streaming #556
Conversation
zizhong
force-pushed
the
response-only-streaming
branch
from
a71203d to
01ef9a6
Compare
There was a problem hiding this comment.
Looking really good. Can we also have integration tests written for these under R2-int-test module? Maybe for the below combinations with the RestRequestStreamResponse API
- Rest Echo and Stream Response
- Timeout
- Rest request Compression
- Stream Response Compression
| import com.linkedin.r2.transport.http.client.common.ErrorChannelFutureListener; | ||
| import com.linkedin.r2.transport.http.client.common.ssl.SslSessionValidator; | ||
| import com.linkedin.r2.transport.http.client.stream.AbstractNettyResponseOnlyStreamClient; | ||
| import com.linkedin.r2.transport.http.client.stream.AbstractNettyStreamClient; |
There was a problem hiding this comment.
Unused import AbstractnettyStreamClient
| * @author Steven Ihde | ||
| * @author Ang Xu | ||
| * @author Zhenkai Zhu |
There was a problem hiding this comment.
Please update the author section since this is a new file
| /** | ||
| * Creates a new HttpNettyStreamClient | ||
| * |
There was a problem hiding this comment.
Create a new ResponseOnlyStreamClient?
| /** | ||
| * @author Steven Ihde | ||
| * @author Ang Xu | ||
| * @author Zhenkai Zhu | ||
| * @author Sean Sheng | ||
| */ |
There was a problem hiding this comment.
Please update the @author section, since this is a new file
|
Put this work on hold as this requires either excessive refactor or additional flags. So that we decided to make the record-and-replay patch to resolve the issue quickly. |
Details can be found in #555.