Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics about xds connection status and count #943

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

bohhyang
Copy link
Contributor

@bohhyang bohhyang commented Oct 12, 2023

Add jmx metrics for xds connection lost, closed, reconnected counts, and its current status of being connected or not.
Will create a container PR to add the corresponding ingraph sensor for the same.

@bohhyang bohhyang requested review from shivamgupta1 and PapaCharlie and removed request for shivamgupta1 October 12, 2023 00:41
@bohhyang bohhyang requested a review from nizarm October 12, 2023 01:18
Copy link
Contributor

@shivamgupta1 shivamgupta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, one minor comment about a comment.

@bohhyang bohhyang requested a review from shivamgupta1 October 13, 2023 01:37
@bohhyang bohhyang merged commit 94c938a into master Oct 13, 2023
2 checks passed
@bohhyang bohhyang deleted the bohan/xDSClientJmx branch October 13, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants