correct where to increment the clusterNotFound count and adjust quarantine log level #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohhyang
requested review from
nizarm,
PapaCharlie,
shivamgupta1 and
brycezhongqing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the clusterNotFound count is incremented when there is no Uris in the cluster in addition to when the cluster config is not found. This change moves it to a place which only increment for cluster config not found.
Also, changing the log level about long-quarantined hosts to Info instead of Error, because 1) often it's just a temporary small capacity which's not causing availability issue. 2) it floods the upstream app's log triggering alerts and/or creating EXC tickets that the upstream app owner is not responsible for. Clarified the log message to show the issue is the downstream host's health.
Test done
build and test