add debug log to dual read caches #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohhyang
requested review from
PapaCharlie,
nizarm,
shivamgupta1,
lauraliu61b,
brycezhongqing and
ZoabKapoor
PapaCharlie
approved these changes
Dec 12, 2023
d2/src/main/java/com/linkedin/d2/balancer/dualread/DualReadLoadBalancerMonitor.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/balancer/dualread/DualReadStateManager.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've seen the Cluster, Service, Uri properties OutOfSync metrics in DualReadLoadBalancer sensor being high for some apps (voyager-api-groups-dash, registration-mt, etc). The metric seems to increment on every update of the property (see attached screenshot of UriPropertiesOutOfSyncCount metric). It bumps up periodically, likely during downstream deployments.
This change added debug logs to when entries are added/compared in the dual read caches to further debug the issue.
Another change is for SI-36476 where D2ClientJmxManager tries to find the right jmx name for d2 services being removed at shutdown (the name depends on dual read mode), causing the executor for getting the dual read mode throws errors since it's already shut down. Added a check to skip getting dual read mode if the executor is shut down (the last read dual read mode will be used).