Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate rest.li build to use Gradle 6.9.4 #977

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

bzzzzzz
Copy link
Contributor

@bzzzzzz bzzzzzz commented Feb 6, 2024

This PR moves rest.li from using Gradle 5.2.1 to Gradle 6.9.4 to build itself. It also drops the support of all Gradle versions before 6.9.4 for the pegasus plugin. Here are the list of changes that made it possible:

  • Gradle service files were automatically updated by the ./gradlew wrapper --gradle-version 6.9.4 command.
  • Gradle testing framework was explicitly configured to run with integTest source set as it is required in newer Gradle version
  • The list of Gradle version to use with testing was standardized in one class
  • PegasusPlugin was configured to accept the PEGASUS_INTEGRATION_TESTING variable because the hack with substituting the integration testing classpath is not possible anymore in newer Gradle versions

Testing Done

  • locally ran ./gradlew build and confirmed that it works

@junchuanwang junchuanwang merged commit 0bf8c62 into linkedin:master Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants