Merge pull request #2 from linkedin/main

Update fork
linkedin · Dec 17, 2024 · 3e09dc2 · 3e09dc2
2 parents 2323177 + c34eb10
commit 3e09dc2
Show file tree

Hide file tree

Showing 302 changed files with 2,386 additions and 53,160 deletions.
diff --git a/.github/rawWorkflows/gh-ci-parameterized-flow.txt b/.github/rawWorkflows/gh-ci-parameterized-flow.txt
@@ -66,3 +66,13 @@
           name: ${{ github.job }}
           path: ${{ github.job }}-jdk${{ matrix.jdk }}-logs.tar.gz
           retention-days: 30
+      - name: Upload test results to BuildPulse for flaky test detection
+        if: '!cancelled()' # Run this step even when the tests fail. Skip if the workflow is cancelled.
+        uses: buildpulse/buildpulse-action@main
+        with:
+          account: 100582612927
+          repository: 100441445875
+          path: |
+            **/TEST-*.xml
+          key: ${{ secrets.BUILDPULSE_ACCESS_KEY_ID }}
+          secret: ${{ secrets.BUILDPULSE_SECRET_ACCESS_KEY }}
diff --git a/.github/workflows/UnitTests-core.yml b/.github/workflows/UnitTests-core.yml
@@ -50,12 +50,14 @@ jobs:
           rsync -R --files-from=artifacts.list . ${{ inputs.artifact_suffix }}-artifacts
           tar -zcvf ${{ inputs.artifact_suffix }}-jdk${{ matrix.jdk }}-logs.tar.gz ${{ inputs.artifact_suffix }}-artifacts
       - name: Publish Test Report
+        continue-on-error: true
         env:
           NODE_OPTIONS: "--max_old_space_size=8192"
         uses: mikepenz/action-junit-report@v3
-        if: always() # always run even if the previous step fails
+        if: always() 
         with:
-          report_paths: '**/build/test-results/test/TEST-*.xml'
+         check_name: ${{ inputs.artifact_suffix }}-jdk${{ matrix.jdk }} Report
+         report_paths: '**/build/test-results/test/TEST-*.xml'
       - name: Upload Build Artifacts
         if: success() || failure()
         uses: actions/upload-artifact@v4

diff --git a/.github/workflows/VeniceCI-CompatibilityTests.yml b/.github/workflows/VeniceCI-CompatibilityTests.yml
@@ -55,27 +55,16 @@ jobs:
         jdk: [8, 11, 17]
     runs-on: ubuntu-latest
     timeout-minutes: 120
-    outputs:
-      alpini_touched: ${{ steps.check_alpini_files_changed.outputs.alpini }}
     steps:
       - uses: actions/checkout@v4
         with:
           # Checkout as many commits as needed for the diff
           fetch-depth: 2
-      - name: Check if files have changed
-        uses: dorny/paths-filter@v3
-        id: check_alpini_files_changed
-        with:
-          filters: |
-            alpini:
-              - 'internal/alpini/**'
       - uses: actions/checkout@v4
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true'
         with:
           fetch-depth: 0
       - name: Set up JDK
         uses: actions/setup-java@v4
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true'
         with:
           java-version: ${{ matrix.jdk }}
           distribution: 'temurin'
@@ -92,101 +81,27 @@ jobs:
       #     echo "java.security file after modifications: "
       #     cat "$JAVA_HOME/conf/security/java.security"
       - shell: bash
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true'
         run: |
           git remote set-head origin --auto
           git remote add upstream https://github.com/linkedin/venice
           git fetch upstream
       - name: Setup Gradle
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true'
         uses: gradle/actions/setup-gradle@v4
       - name: Run alpini unit tests
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true'
         run: ./gradlew --continue --no-daemon -DmaxParallelForks=1 alpiniUnitTest
       - name: Package Build Artifacts
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true' && (success() || failure())
+        if: (success() || failure())
         shell: bash
         run: |
           mkdir ${{ github.job }}-artifacts
           find . -path "**/build/reports/*" -or -path "**/build/test-results/*" > artifacts.list
           rsync -R --files-from=artifacts.list . ${{ github.job }}-artifacts
           tar -zcvf ${{ github.job }}-jdk${{ matrix.jdk }}-logs.tar.gz ${{ github.job }}-artifacts
       - name: Upload Build Artifacts
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true' && (success() || failure())
+        if: (success() || failure())
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ github.job }}
-          path: ${{ github.job }}-jdk${{ matrix.jdk }}-logs.tar.gz
-          retention-days: 30
-
-  AlpiniFunctionalTests:
-    strategy:
-      fail-fast: false
-      matrix:
-        jdk: [17]
-    runs-on: ubuntu-latest
-    timeout-minutes: 120
-    outputs:
-      alpini_touched: ${{ steps.check_alpini_files_changed.outputs.alpini }}
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          # Checkout as many commits as needed for the diff
-          fetch-depth: 2
-      - name: Check if files have changed
-        uses: dorny/paths-filter@v3
-        id: check_alpini_files_changed
-        with:
-          filters: |
-            alpini:
-              - 'internal/alpini/**'
-      - uses: actions/checkout@v4
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true'
-        with:
-          fetch-depth: 0
-      - name: Set up JDK
-        uses: actions/setup-java@v4
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true'
-        with:
-          java-version: ${{ matrix.jdk }}
-          distribution: 'temurin'
-          cache: 'gradle'
-      # - name: Allow Deprecated TLS versions for Alpini tests
-      #   run: |
-      #     echo "java.security file before modifications: "
-      #     cat "$JAVA_HOME/conf/security/java.security"
-
-      #     # This is possibly flaky but
-      #     sed -i 's/TLSv1, //g' "$JAVA_HOME/conf/security/java.security" # Allow TLSv1
-      #     sed -i 's/TLSv1.1, //g' "$JAVA_HOME/conf/security/java.security" # Allow TLSv1.1
-
-      #     echo "java.security file after modifications: "
-      #     cat "$JAVA_HOME/conf/security/java.security"
-      - shell: bash
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true'
-        run: |
-          git remote set-head origin --auto
-          git remote add upstream https://github.com/linkedin/venice
-          git fetch upstream
-      - name: Setup Gradle
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true'
-        uses: gradle/actions/setup-gradle@v4
-      - name: Run alpini functional tests
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true'
-        run: ./gradlew --continue --no-daemon -DmaxParallelForks=1 alpiniFunctionalTest
-      - name: Package Build Artifacts
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true' && (success() || failure())
-        shell: bash
-        run: |
-          mkdir ${{ github.job }}-artifacts
-          find . -path "**/build/reports/*" -or -path "**/build/test-results/*" > artifacts.list
-          rsync -R --files-from=artifacts.list . ${{ github.job }}-artifacts
-          tar -zcvf ${{ github.job }}-jdk${{ matrix.jdk }}-logs.tar.gz ${{ github.job }}-artifacts
-      - name: Upload Build Artifacts
-        if: steps.check_alpini_files_changed.outputs.alpini == 'true' && (success() || failure())
-        uses: actions/upload-artifact@v4
-        with:
-          name: ${{ github.job }}
+          name: ${{ github.job }}-jdk${{ matrix.jdk }}
           path: ${{ github.job }}-jdk${{ matrix.jdk }}-logs.tar.gz
           retention-days: 30
 
@@ -257,7 +172,7 @@ jobs:
     strategy:
       fail-fast: false
     runs-on: ubuntu-latest
-    needs: [AvroCompatibilityTests, AlpiniUnitTests, AlpiniFunctionalTests, PulsarVeniceIntegrationTests]
+    needs: [AvroCompatibilityTests, AlpiniUnitTests, PulsarVeniceIntegrationTests]
     timeout-minutes: 120
     steps:
       - name: AllIsWell