[controller][PR] in ControllerClient::getStoresForCompaction, modify …

…QueryParams initialisation to take explicit clusterName directly
linkedin · Dec 10, 2024 · 5a5dddb · 5a5dddb
1 parent b93c6fc
commit 5a5dddb
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/internal/venice-common/src/main/java/com/linkedin/venice/controllerapi/ControllerClient.java b/internal/venice-common/src/main/java/com/linkedin/venice/controllerapi/ControllerClient.java
@@ -1162,18 +1162,20 @@ public MultiStoreInfoResponse getClusterStores(String clusterName) {
    * @return The list of store names that are ready for compaction.
    */
   public MultiStoreInfoResponse getStoresForCompaction(String clusterName) {
-    QueryParams params = newParams().add(CLUSTER, clusterName);
+    QueryParams params = new QueryParams().add(CLUSTER, clusterName);
     return request(ControllerRoute.GET_STORES_FOR_COMPACTION, params, MultiStoreInfoResponse.class);
   }
 
   /**
-   * This method triggers repush for storeName
+   * This method triggers an adhoc repush for storeName
    * @param storeName
-   * @return //TODO
+   * @return //TODO LC:
    */
-  public ControllerResponse triggerRepush(String storeName) {
+  public ControllerResponse triggerRepush(String storeName, byte[] repushJobDetails) {
     QueryParams params = newParams().add(NAME, storeName);
-    return request(ControllerRoute.COMPACT_STORE, params, ControllerResponse.class);
+    // TODO LC: add params from admin tool for repush: e.g. version, fabric etc.
+    // TODO LC: add admin.repush()
+    return request(ControllerRoute.COMPACT_STORE, params, ControllerResponse.class, repushJobDetails);
   }
 
   public VersionResponse getStoreLargestUsedVersion(String clusterName, String storeName) {